ch4: shm: fix data type for recv_bytes in MPIDI_POSIX_mpi_release_gat…#7665
Merged
hzhou merged 1 commit intopmodels:mainfrom Dec 18, 2025
Merged
ch4: shm: fix data type for recv_bytes in MPIDI_POSIX_mpi_release_gat…#7665hzhou merged 1 commit intopmodels:mainfrom
hzhou merged 1 commit intopmodels:mainfrom
Conversation
nmorey
force-pushed
the
dev/master/aint
branch
from
19c1b65 to
c601c0f
Compare
nmorey
force-pushed
the
dev/master/aint
branch
3 times, most recently
from
e793354 to
54cd785
Compare
Contributor
|
test:mpich/ch3/most |
…her_release The number of received bytes in release_gather_release is badly cast between int and MPI_Aint. On most arch this is not an issue, but for Big-Endian 64b arch (s390x) it ends up losing the actual value as we only copy the first 4 MSB. Fix the issue by writing the whole MPI_AInt in the shm_buf instead of just an int. Signed-off-by: Nicolas Morey <[email protected]>
hzhou
force-pushed
the
dev/master/aint
branch
from
54cd785 to
eed5279
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The number of received bytes in release_gather_release is badly cast between int and MPI_Aint. On most arch this is not an issue, but for Big-Endian 64b arch (s390x) it ends up losing the actual value.
Fix the issue but writing the whole MPI_AInt in the shm_buf instead of just an int.
This bug was found on 4.3.2 while debugging on s390x with ch4:ofi: