Skip to content

Commit

Permalink
Merge pull request #360 from appieschot/feature/html-fixes
Browse files Browse the repository at this point in the history
[feature] added html lang. solves #359
  • Loading branch information
stephanbisser authored Apr 3, 2023
2 parents c1af5b7 + 4e505d0 commit d1953d9
Show file tree
Hide file tree
Showing 10 changed files with 41 additions and 41 deletions.
10 changes: 5 additions & 5 deletions packages/generator-teams/src/app/templates/src/public/index.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title>
<%= title %>
</title>
Expand All @@ -15,7 +15,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -34,10 +34,10 @@ <h1>Welcome to the <em><%= title %></em></h1>
<article class="l-article">
<p><%= description %></p>
<% if (botType == 'botframework') { %>
<p>Add the bot to Microsoft Teams:
<p>Add the bot to Microsoft Teams:
<a href='https://teams.microsoft.com/l/chat/0/0?users=28:{{<%= botidEnv %>}}'><img alt="Add bot to Teams" height="30" width="113" src='https://dev.botframework.com/Client/Images/Add-To-MSTeams-Buttons.png'></a></p>
<% } %>
</article>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title>
<%= title %> - Privacy
</title>
Expand All @@ -24,7 +24,7 @@
<header class="l-header">
<div class="logo">
<img src="https://static2.sharepointonline.com/files/fabric/assets/brand-icons/product-fluent/svg/teams_48x1.svg"
alt="Teams logo"
alt="Teams logo"
class="logo">
</div>
<div class="l-title">
Expand All @@ -38,4 +38,4 @@ <h1><%= title %> Privacy</h1>
</article>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title>
<%= title %> - Terms of Use
</title>
Expand All @@ -24,7 +24,7 @@
<header class="l-header">
<div class="logo">
<img src="https://static2.sharepointonline.com/files/fabric/assets/brand-icons/product-fluent/svg/teams_48x1.svg"
alt="Teams logo"
alt="Teams logo"
class="logo">
</div>
<div class="l-title">
Expand All @@ -38,4 +38,4 @@ <h1><%= title %> Terms of Use</h1>
</article>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= staticTabTitle %></title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -29,4 +29,4 @@
</script>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= connectorTitle %></title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -30,4 +30,4 @@
</script>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= messageExtensionTitle %> Action</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -29,4 +29,4 @@
</script>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= messageExtensionTitle %> Configuration</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -29,4 +29,4 @@
</script>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= tabTitle %>: Configuration</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -30,4 +30,4 @@

</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= tabTitle %></title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -29,4 +29,4 @@
</script>
</body>

</html>
</html>
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<!DOCTYPE html>
<html>
<html lang="en" xml:lang="en">

<head>
<meta charset="UTF-8">
<meta content="text/html; charset=utf-8" />
<title><%= tabTitle %>: Remove</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<!-- inject:css -->
Expand All @@ -13,7 +13,7 @@
}({
instrumentationKey: "{{APPINSIGHTS_INSTRUMENTATIONKEY}}"
});

window.appInsights = appInsights, appInsights.queue && 0 === appInsights.queue.length && appInsights.trackPageView();
</script><% } %>
</head>
Expand All @@ -29,4 +29,4 @@
</script>
</body>

</html>
</html>

0 comments on commit d1953d9

Please sign in to comment.