Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update task definitions and environment setup for food catalog sample #71

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

garrytrinder
Copy link
Member

@garrytrinder garrytrinder commented Dec 13, 2024

Merging this PR will update the nodejs-typescript-food-catalog sample:

  • We now have two stages in the YAML file instead of one
    • Provision
      • Ensures Azure Functions Core Tools v4 are installed
      • Executes npm install
    • Deploy
      • Contains the original tasks
  • Early exit if Dev Tunnels CLI is not installed
    • We ensure the env files, then run the Dev Tunnels script before anything else
    • If CLI is not installed, the whole process stops and a message is shown with a link to docs with install info in the terminal output
  • After ensuring the Dev Tunnel
    • We run the tasks in the Provision stage in YAML file
    • We start the Azurite service
    • We run the tasks in the Deploy stage in YAML file
  • Fixes issue where NOTIFICATION_DOMAIN env var was not being created
  • Tasks are no longer executed if the previous task in the sequence fails

@waldekmastykarz waldekmastykarz merged commit 236406f into pnp:main Dec 13, 2024
1 check passed
@garrytrinder garrytrinder deleted the foodsie-tasks branch December 13, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants