Optimizing file upload speed by reducing the number of API calls#764
Draft
heinrich-ulbricht wants to merge 1 commit intopnp:devfrom
Draft
Optimizing file upload speed by reducing the number of API calls#764heinrich-ulbricht wants to merge 1 commit intopnp:devfrom
heinrich-ulbricht wants to merge 1 commit intopnp:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains the following parts:
This speeds up uploading of files if they go to the same folder. I'm uploading dozens, sometimes hundreds of file to the same folder. This used to take about 1,5-2 seconds per file. With those changes it's down to 0,75-1 second. (Rough estimate by looking at the console timestamps.) So this is now ~twice as fast.
But I'm creating this pull request as draft because I'm not entirely sure point 3 from the list is correct (this is about
PublishFileToLevel). It looks correct but I don't know if this causes side effects to disappear that are actually needed somewhere. Maybe somebody can confirm that it is ok to check the existing level before trying to adjust it.