Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gym-membership-reg-app #101

Closed
wants to merge 31 commits into from

Conversation

Marvelous-O
Copy link

@Marvelous-O Marvelous-O commented Jul 16, 2024

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

  • Bug fix?
  • New sample?
  • Related issues: fixes #X, partially #Y, mentioned in #Z
  • Needs API permissions?
  • Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

First Sample Submission.

Checklist

  • My pull request affects only ONE sample.
  • I have updated the README file.
  • My README has at least one static high-resolution screenshot (i.e. not a GIF)
  • My README contains complete setup instructions, including pre-requisites and permissions required

@Katerina-Chernevskaya
Copy link
Contributor

Hi @Marvelous-O,

Thank you for your sample!
When I tried to import the solution, I got an error related to Missing Dependencies:
image
Could you please check that all components of the solution are in place?

Also please rename the folder to keep only lower case. And please review the installation guide - if your solution required a SharePoint site or library, please specify prerequisites for this (what should be created in advance).

Thank you!

@Katerina-Chernevskaya Katerina-Chernevskaya added the Needs Attention Something needs to be fixed with the PR before merging label Jul 31, 2024
@Marvelous-O Marvelous-O changed the title Gym membership Reg app gym-membership-reg-app Aug 2, 2024
Copy link
Author

@Marvelous-O Marvelous-O left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katerina-Chernevskaya Made Changes, please verify

@Marvelous-O Marvelous-O changed the base branch from main to Docs August 3, 2024 16:38
@Marvelous-O Marvelous-O changed the base branch from Docs to katerinachernevskaya-update-sample-json August 3, 2024 16:38
@Marvelous-O Marvelous-O changed the base branch from katerinachernevskaya-update-sample-json to main August 3, 2024 16:38
@Katerina-Chernevskaya
Copy link
Contributor

Hi @Marvelous-O ,

The error with missing dependencies still reproduced. Could you please check once again, especially connection references?

Thank you!

Deleted the previous zip solution file and uploaded a new one
Updated README File and gave instructions on how to set up the  Data Source.
Deleted the previous solution zip file and uploaded a new one
Updated README File and gave instructions on how to set up the Data Source
@Marvelous-O
Copy link
Author

Hi @Katerina-Chernevskaya, Made Changes, please verify. Thank you

@Marvelous-O Marvelous-O deleted the Gym-Membership-Reg-App branch October 27, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention Something needs to be fixed with the PR before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants