updated SecurityRoleManament and added new Sample

[StuartBaxter-MVP]

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

To submit a pull request with multiple authors, make sure that at least one commit is a co-authored commit by adding a Co-authored-by: trailer to the commit's message. E.g.: Co-authored-by: name <[email protected]>

Put an x in all the items that apply ([x], without spaces), make notes next to any that haven't been addressed.

• Bug fix?
• New sample?
• Related issues: fixes #X, partially #Y, mentioned in #Z
• Needs API permissions?
• Has other prerequisites? (E.g. requires a list, document library, etc.)

What's in this Pull Request?

Corrected bug in Security role management app and added new sample (Modern Controls Demo)

Checklist

This checklist is mostly useful as a reminder of small things that can easily be forgotten – it is meant as a helpful tool rather than hoops to jump through.

Put an x in all the items that apply ([x], no spaces), make notes next to any that haven't been addressed.

• My pull request affects only ONE sample.
• I have updated the README file.
• My README has at least one static high-resolution screenshot (i.e. not a GIF)
• My README contains complete setup instructions, including pre-requisites and permissions required

[StuartBaxter-MVP]

Please reach out if anything doesn't look quite right

[Katerina-Chernevskaya]

Hi @StuartBaxter-MVP,

Thank you for your contribution!

Upon reviewing your PR, it has come to my attention that two folders were included: 'ModernControls' and 'security-role-management', although the pR refers to 'SecurityRoleManagement'. I would like to kindly seek clarification on whether your intention is to submit both samples or just the one pertaining to security role management.
To facilitate a seamless review process, I would kindly request that you initiate a new branch in your fork, and create a PR from this new branch targeting the main branch, following the steps outlined here. If your intention is to submit both samples, it would be greatly appreciated if you could create two separate branches and corresponding PRs. This will significantly streamline our review process, ensuring that each submission received the attention it warrants.

Your cooperation and understanding in this matter are highly esteemed.

Kind regards,
Katerina Chernevskaya

[StuartBaxter-MVP]

Hi Katerina, It's two samples, security role management and modern controls. I'll create another branch and PR tomorrow for you and resubmit thanks Stuart

…

-------- Original Message --------

On 30 Oct 2023, 17:48, Katerina Chernevskaya wrote: Hi ***@***.***(https://github.com/StuartBaxter-MVP), Thank you for your contribution! Upon reviewing your PR, it has come to my attention that two folders were included: 'ModernControls' and 'security-role-management', although the pR refers to 'SecurityRoleManagement'. I would like to kindly seek clarification on whether your intention is to submit both samples or just the one pertaining to security role management. To facilitate a seamless review process, I would kindly request that you initiate a new branch in your fork, and create a PR from this new branch targeting the main branch, following the steps outlined [here](https://github.com/pnp/powerplatform-samples/blob/main/CONTRIBUTING.md#submitting-pull-requests). If your intention is to submit both samples, it would be greatly appreciated if you could create two separate branches and corresponding PRs. This will significantly streamline our review process, ensuring that each submission received the attention it warrants. Your cooperation and understanding in this matter are highly esteemed. Kind regards, Katerina Chernevskaya — Reply to this email directly, [view it on GitHub](#44 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AV5CBCBGVXKJWMBHDMP6K73YB7R6NAVCNFSM6AAAAAA5UQ3WX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBVG42TANJXGY). You are receiving this because you were mentioned.Message ID: ***@***.***>