Add PSVersionUtility to retrieve PowerShell version and update cmdlets for admin checks #4788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for admin checks
…ion and remove deprecated PSVersionUtility class
KoenZomers
reviewed
Mar 13, 2025
KoenZomers
reviewed
Mar 13, 2025
| @@ -94,6 +94,11 @@ public class RegisterAzureADApp : BasePSCmdlet, IDynamicParameters | |||
|
|
|||
| protected override void ProcessRecord() | |||
| { | |||
| if (PSUtility.IsUserLocalAdmin()) | |||
| { | |||
| WriteWarning("Running this cmdlet in requires you to run PowerShell as an administrator due to a regression in .NET 9."); | |||
There was a problem hiding this comment.
Maybe use the word bug instead of regression? More (non dev) people will understand that better, I would think?
KoenZomers
reviewed
Mar 13, 2025
KoenZomers
reviewed
Mar 13, 2025
src/Commands/Utilities/PSUtility.cs
Outdated
| { | ||
| return new System.Security.Principal.WindowsPrincipal(System.Security.Principal.WindowsIdentity.GetCurrent()).IsInRole(System.Security.Principal.WindowsBuiltInRole.Administrator); | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Should this not be a return null as it cannot be defined in this case?
There was a problem hiding this comment.
This only impacts Windows , for the rest , it works fine.
KoenZomers
reviewed
Mar 13, 2025
| }); | ||
|
|
||
| #pragma warning disable CA1416 // Validate platform compatibility | ||
| public static bool IsUserLocalAdmin() |
There was a problem hiding this comment.
Make a nillable bool? See comment below.
There was a problem hiding this comment.
This only impacts Windows , for the rest , it works fine.
added 5 commits
March 13, 2025 22:23
…refine local admin verification in PSUtility
… permissions needed
…rtificate generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/pnp/powerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
Fixes #X, partially fixes #Y, mentioned in #Z, etc.
What is in this Pull Request ?
Please describe the changes in the PR.
Guidance