-
Notifications
You must be signed in to change notification settings - Fork 23
Refactors welcome experience. Closes #461 #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@nicodecleyre I think this PR actually breaks the tests. |
Hmm, not sure.. i noticed this timeout error on other pr's and after a couple of retries, it passes. Can we upgrade the timeout number? |
We are increasing the timeout as part of #513, that's yet to be merged. This should be enough as other tests are expected to complete within less than 2000 ms limit. If not, we can consider updating the global mocha timeout configuration. |
this is what I already did locally the same way like in your (@Saurabh7019) PR but locally unfortunately this test was still always failing so I think some work from my side is still required to get this done 👍 |
27c83c4
to
92d81c3
Compare
I recheck this locally and yes the tests are failing due to the way I now change the extension activates. |
92d81c3
to
290c30a
Compare
@nicodecleyre the PR is ready 🚀 |
Thank you! Will review asap 🤩 |
68a1416
to
e5696ca
Compare
@nicodecleyre I was wondering if we could get this merged as well. I think the PR is ready and we could clear up the PRs even if we are blocked from pre-releases |
e5696ca
to
2ea286f
Compare
2ea286f
to
1583023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change! Thank you for your contribution 🤩
🎯 Aim
The aim of this PR is to completly rebuild the welcome experience of SPFx Toolkit allowing more capabilities that are present no only in context of an SPFx project like allowing to sign in and manage your apps.
📷 Result
✅ What was done
🔗 Related issue
Closes #461