Skip to content

Refactors welcome experience. Closes #461 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2025

Conversation

Adam-it
Copy link
Member

@Adam-it Adam-it commented Jun 12, 2025

🎯 Aim

The aim of this PR is to completly rebuild the welcome experience of SPFx Toolkit allowing more capabilities that are present no only in context of an SPFx project like allowing to sign in and manage your apps.

📷 Result

welcome-experience

✅ What was done

  • Dropped all experience
  • Added account, app catalog, actions, help views
  • Updated actions view
  • Updated docs

🔗 Related issue

Closes #461

@Adam-it
Copy link
Member Author

Adam-it commented Jun 15, 2025

@nicodecleyre I think this PR actually breaks the tests.
I had attempted to fix it locally but due to lack of energy and time I didn't finish and merge this yet. Will do that next week (like tomorrow or something 😉)
👍

@Adam-it Adam-it marked this pull request as draft June 15, 2025 20:59
@nicodecleyre
Copy link
Collaborator

@nicodecleyre I think this PR actually breaks the tests.
I had attempted to fix it locally but due to lack of energy and time I didn't finish and merge this yet. Will do that next week (like tomorrow or something 😉)
👍

Hmm, not sure.. i noticed this timeout error on other pr's and after a couple of retries, it passes. Can we upgrade the timeout number?

@Saurabh7019
Copy link
Collaborator

We are increasing the timeout as part of #513, that's yet to be merged. This should be enough as other tests are expected to complete within less than 2000 ms limit. If not, we can consider updating the global mocha timeout configuration.

@Adam-it
Copy link
Member Author

Adam-it commented Jun 16, 2025

We are increasing the timeout as part of #513, that's yet to be merged. This should be enough as other tests are expected to complete within less than 2000 ms limit. If not, we can consider updating the global mocha timeout configuration.

this is what I already did locally the same way like in your (@Saurabh7019) PR but locally unfortunately this test was still always failing so I think some work from my side is still required to get this done 👍

@Adam-it Adam-it force-pushed the refactor-welcome-experience branch from 27c83c4 to 92d81c3 Compare June 16, 2025 20:22
@Adam-it
Copy link
Member Author

Adam-it commented Jun 17, 2025

I recheck this locally and yes the tests are failing due to the way I now change the extension activates.
I already corrected it locally but I plan to add more tests for the new welcome experience. I should have them ready in a few days

@Adam-it Adam-it force-pushed the refactor-welcome-experience branch from 92d81c3 to 290c30a Compare June 17, 2025 22:35
@Adam-it Adam-it marked this pull request as ready for review June 17, 2025 22:39
@Adam-it
Copy link
Member Author

Adam-it commented Jun 17, 2025

@nicodecleyre the PR is ready 🚀

@nicodecleyre
Copy link
Collaborator

@nicodecleyre the PR is ready 🚀

Thank you! Will review asap 🤩

@Adam-it Adam-it force-pushed the refactor-welcome-experience branch 2 times, most recently from 68a1416 to e5696ca Compare June 26, 2025 22:21
@Adam-it
Copy link
Member Author

Adam-it commented Jul 14, 2025

@nicodecleyre the PR is ready 🚀

Thank you! Will review asap 🤩

@nicodecleyre I was wondering if we could get this merged as well. I think the PR is ready and we could clear up the PRs even if we are blocked from pre-releases

@Adam-it Adam-it force-pushed the refactor-welcome-experience branch from e5696ca to 2ea286f Compare July 14, 2025 22:24
@Adam-it Adam-it force-pushed the refactor-welcome-experience branch from 2ea286f to 1583023 Compare July 18, 2025 20:59
Copy link
Collaborator

@nicodecleyre nicodecleyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change! Thank you for your contribution 🤩

@nicodecleyre nicodecleyre merged commit 867a22f into pnp:dev Jul 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [Feature]: Allow to use some SPFx Toolkit Capabilities not only in context of SPFx project
3 participants