Added missing redirect URI steps for manual Entra app registration. Closes #528 #530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @nirav-raval 🤩, we will review ASAP. |
|
@nirav-raval as discussed in the related issue please do remember to update the docs as well 👍 |
nicodecleyre
requested changes
Jul 4, 2025
src/webview/view/components/forms/entraAppReg/RegisterEntraAppRegView.tsx
Outdated
Show resolved
Hide resolved
src/webview/view/components/forms/entraAppReg/RegisterEntraAppRegView.tsx
Outdated
Show resolved
Hide resolved
|
Looking solid @nirav-raval 💪. When you have a moment, could you take a look at the small changes I mentioned and sync with the latest from |
Adam-it
force-pushed
the
feat/update-entra-app-registration-fixes-528
branch
from
5c5d8c6 to
69686d9
Compare
@nicodecleyre if this PR is ready to merge lets do so. |
## 🎯 Aim Update the node version in all GitHub workflows to v22 ## 📷 Result N/A ## ✅ What was done Updated the node version in all GitHub workflows to v22 - [X] done ## 🔗 Related issue Closes: #[485](pnp#485)
## 🎯 Aim The aim is to update issue templates to include the additional "👀 needs peer review" label and issue type ## ✅ What was done - [X] updated issue templates ## 🔗 Related issue Closes: pnp#475 Co-authored-by: Nico De Cleyre <[email protected]>
… group across 1 directory (pnp#520) Bumps the npm_and_yarn group with 1 update in the /docs directory: [brace-expansion](https://github.com/juliangruber/brace-expansion). Updates `brace-expansion` from 2.0.1 to 2.0.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/juliangruber/brace-expansion/releases">brace-expansion's releases</a>.</em></p> <blockquote> <h2>v2.0.2</h2> <ul> <li>pkg: publish on tag 2.x 14f1d91</li> <li>fmt ed7780a</li> <li>Fix potential ReDoS Vulnerability or Inefficient Regular Expression (<a href="https://redirect.github.com/juliangruber/brace-expansion/issues/65">#65</a>) 36603d5</li> </ul> <hr /> <p><a href="https://github.com/juliangruber/brace-expansion/compare/v2.0.1...v2.0.2">https://github.com/juliangruber/brace-expansion/compare/v2.0.1...v2.0.2</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/juliangruber/brace-expansion/commit/c85b8ad3f53d1eb65f4996a495cae61949855f7c"><code>c85b8ad</code></a> 4.0.1</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/5a5cc176c080b2fde292a9815dc6ecd97c870d17"><code>5a5cc17</code></a> fmt</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/0b6a9781e18e9d2769bb2931f4856d1360243ed2"><code>0b6a978</code></a> Fix potential ReDoS Vulnerability or Inefficient Regular Expression (<a href="https://redirect.github.com/juliangruber/brace-expansion/issues/65">#65</a>)</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/6a39bdddcf944374b475d99b0e8292d3727c7ebe"><code>6a39bdd</code></a> 4.0.0</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/dd72a59047e30ea265c4a58695a00ea82e90a437"><code>dd72a59</code></a> fmt</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/278132b187d4418fe8163da5e81710222f47e3f6"><code>278132b</code></a> feat: use string replaces instead of splits (<a href="https://redirect.github.com/juliangruber/brace-expansion/issues/64">#64</a>)</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/70e4c1baf9b91c77b1fa303a0c07d35389e9c0a0"><code>70e4c1b</code></a> add <code>tea.yaml</code></li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/b01a637b0578a7c59acc7d8386f11f8d0710b512"><code>b01a637</code></a> 3.0.0</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/9e781e913fe323e69248d36acebe29008666ba72"><code>9e781e9</code></a> node 16 is EOL</li> <li><a href="https://github.com/juliangruber/brace-expansion/commit/6dad2093f84eac403fb3715a624fede524967cec"><code>6dad209</code></a> docs</li> <li>Additional commits viewable in <a href="https://github.com/juliangruber/brace-expansion/compare/v2.0.1...v2.0.2">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore <dependency name> major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore <dependency name> minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore <dependency name>` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore <dependency name>` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore <dependency name> <ignore condition>` will remove the ignore condition of the specified dependency and ignore conditions You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/pnp/vscode-viva/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Automated check and update of SPFx extensions and webparts samples data and aces sample data. Co-authored-by: Adam-it <[email protected]>
Automated check and update of SPFx extensions and webparts samples data and aces sample data. Co-authored-by: Adam-it <[email protected]>
## 🎯 Aim Refactors getting started page. ## 📷 Result  ## ✅ What was done - [ ] getting started recording not updated! - [X] Updated download section and added a placeholder for video - [X] Updated release & pre-release section with details and screenshots - [X] Moved bundle section down - [X] Update Bug section - [X] Added Feature request section ## 🔗 Related issue pnp#491 --------- Co-authored-by: Adam Wójcik <[email protected]>
Adam-it
force-pushed
the
feat/update-entra-app-registration-fixes-528
branch
from
69686d9 to
9a397f6
Compare
nicodecleyre
approved these changes
Jul 17, 2025
|
@nirav-raval, @nicodecleyre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Aim
When using the Log in to Microsoft 365 option from the SPFx Toolkit in VS Code, there are a set of instructions to manually set up the App Registration. They do not include instructions to add http://localhost/ or https://localhost/ as valid Redirect URIs. This causes the login process to fail with the errorWhen using the Log in to Microsoft 365 option from the SPFx Toolkit in VS Code, there are a set of instructions to manually set up the App Registration. They do not include instructions to add http://localhost/ or https://localhost/ as valid Redirect URIs. This causes the login process to fail with the error.
📷 Result
N/A
✅ What was done
🔗 Related issue
Closes: #528