fix(minimalist): correctly save/restore boolean vs numeric options #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, I could not exit a mode (like ataraxis). I got an errors like, `Invalid value for option 'cmdheight': expected number, got boolean true stack traceback`. This is because save_opts() in minimalist.lua coerced numeric options into booleans, and the issue was caused when off() was called. I get no errors after the patch and I can use off() just fine. I used nvim_get_all_options() to check the option type and store booleans as true/false while leaving unmeric and string options untouched, which seems like the sensible, future-proof way to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, I could not exit a mode (like ataraxis). I got an errors like,
Invalid value for option 'cmdheight': expected number, got boolean true.This is because save_opts() in minimalist.lua coerced numeric options into booleans, and the issue was caused when off() was called. I get no errors after the patch and I can use off() just fine. To fix, I used nvim_get_all_options() to check the option type and store booleans as true/false while leaving numeric and string options untouched, which seems like the sensible, future-proof way to do this.