Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve text parsing on name registration #44

Merged
merged 2 commits into from
May 5, 2024
Merged

Improve text parsing on name registration #44

merged 2 commits into from
May 5, 2024

Conversation

raahii
Copy link
Contributor

@raahii raahii commented May 5, 2024

名前登録時のコマンドのパースを改善する

  • 「だよ〜」とか「だよ!」でも受け付ける
  • 名前の後にスペースが入ったらトリムする

この辺の記号がつくケース、将来的には共通的に正規化していきたい....

@raahii raahii self-assigned this May 5, 2024
Copy link

cloudflare-workers-and-pages bot commented May 5, 2024

Deploying haraiai with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1211e73
Status: ✅  Deploy successful!
Preview URL: https://487edccc.haraiai.pages.dev
Branch Preview URL: https://improve-setup.haraiai.pages.dev

View logs

Copy link

github-actions bot commented May 5, 2024

Terraform Initialization ⚙️success

Terraform Plan 📖success

Terraform Validation 🤖success

Show Plan
data.archive_file.bot: Reading...
data.google_secret_manager_secret_version.line_bot_channel_access_token: Reading...
data.google_secret_manager_secret_version.line_bot_channel_secret: Reading...
google_storage_bucket.bucket: Refreshing state... [id=haraiai-bucket]
data.archive_file.bot: Read complete after 1s [id=ec04e56dc78b695b4882097fe12f6e02858139b9]
google_storage_bucket_object.bot: Refreshing state... [id=haraiai-bucket-func/bot.83b71829bd57152cb18305c0103e482d.zip]
data.google_secret_manager_secret_version.line_bot_channel_secret: Read complete after 1s [id=projects/900543910035/secrets/lineBotChannelSecret/versions/1]
data.google_secret_manager_secret_version.line_bot_channel_access_token: Read complete after 1s [id=projects/900543910035/secrets/lineBotChannelAccessToken/versions/1]
google_cloudfunctions_function.bot_webhook: Refreshing state... [id=projects/haraiai/locations/asia-northeast1/functions/BotWebhookHandler]
google_cloudfunctions_function_iam_member.webhook_invoker: Refreshing state... [id=projects/haraiai/locations/asia-northeast1/functions/BotWebhookHandler/roles/cloudfunctions.invoker/allUsers]

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # google_cloudfunctions_function.bot_webhook will be updated in-place
  ~ resource "google_cloudfunctions_function" "bot_webhook" {
        id                           = "projects/haraiai/locations/asia-northeast1/functions/BotWebhookHandler"
        name                         = "BotWebhookHandler"
      ~ source_archive_object        = "func/bot.83b71829bd57152cb18305c0103e482d.zip" -> "func/bot.75ee0babf5fc31b0bf74e47b84fe5f7f.zip"
        # (22 unchanged attributes hidden)
    }

  # google_storage_bucket_object.bot must be replaced
-/+ resource "google_storage_bucket_object" "bot" {
      + content          = (sensitive value)
      ~ content_type     = "application/zip" -> (known after apply)
      ~ crc32c           = "G4s1PQ==" -> (known after apply)
      ~ detect_md5hash   = "g7cYKb1XFSyxgwXAED5ILQ==" -> "different hash" # forces replacement
      - event_based_hold = false -> null
      ~ id               = "haraiai-bucket-func/bot.83b71829bd57152cb18305c0103e482d.zip" -> (known after apply)
      + kms_key_name     = (known after apply)
      ~ md5hash          = "g7cYKb1XFSyxgwXAED5ILQ==" -> (known after apply)
      ~ media_link       = "https://storage.googleapis.com/download/storage/v1/b/haraiai-bucket/o/func%2Fbot.83b71829bd57152cb18305c0103e482d.zip?generation=1694938213917840&alt=media" -> (known after apply)
      - metadata         = {} -> null
      ~ name             = "func/bot.83b71829bd57152cb18305c0103e482d.zip" -> "func/bot.75ee0babf5fc31b0bf74e47b84fe5f7f.zip" # forces replacement
      ~ output_name      = "func/bot.83b71829bd57152cb18305c0103e482d.zip" -> (known after apply)
      ~ self_link        = "https://www.googleapis.com/storage/v1/b/haraiai-bucket/o/func%2Fbot.83b71829bd57152cb18305c0103e482d.zip" -> (known after apply)
      ~ storage_class    = "STANDARD" -> (known after apply)
      - temporary_hold   = false -> null
        # (2 unchanged attributes hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.

─────────────────────────────────────────────────────────────────────────────

Note: You didn't use the -out option to save this plan, so Terraform can't
guarantee to take exactly these actions if you run "terraform apply" now.

Pushed by: @raahii, Action: pull_request

@@ -11,6 +11,7 @@ clean:
rm -rf $(FUNC_BOT)/vendor
rm -rf $(FUNC_BOT)/messaging
rm -rf pkg/mock
rm -rf pkg/wire/wire_gen.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wire_gen.go を削除してからでないと go generate がSEGVで死ぬ、うーんなぜだ

@raahii raahii merged commit d8d1d3a into main May 5, 2024
5 checks passed
@raahii raahii deleted the improve-setup branch May 5, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant