Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourage using configure/make to build Poco #4463

Closed
wants to merge 1 commit into from

Conversation

matejk
Copy link
Contributor

@matejk matejk commented Feb 16, 2024

CMake is officially supported build system for building Poco.

To discourage using configure and make, a warning is printed and the user has to explicitly force usage of configure script.

@matejk matejk marked this pull request as draft February 16, 2024 09:44
Copy link
Member

@aleks-f aleks-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about this. I don't want this obstacle for my own reasons but, more importantly, likely most packagers use make.

I suggest to just make sure the documentation is kept accurate and clear about cmake being the official build system

!!Building using CMake

@matejk
Copy link
Contributor Author

matejk commented Feb 16, 2024

Linux packagers seem to use cmake (at least Fedora, Debian and Ubuntu).

What about having just a message?

@aleks-f
Copy link
Member

aleks-f commented Feb 16, 2024

Linux packagers seem to use cmake (at least Fedora, Debian and Ubuntu).

What about having just a message?

Message only is fine, I think the documentation is the most important part, so we have no strict obligation to keep it absolutely immaculate - just RTFM anyone complaining about it.

@matejk matejk force-pushed the discourage-using-configure-and-make branch from d247805 to f1b2cc0 Compare February 19, 2024 18:59
@matejk matejk deleted the branch devel April 15, 2024 11:20
@matejk matejk closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants