Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 229 - Create new database tables for version D collections #260

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

torimcd
Copy link
Collaborator

@torimcd torimcd commented Oct 31, 2024

Github Issue: closes #229 - Create new database tables for version D collections

Description

New SWOT hydrology data collections are coming in January 2025. We need new database tables to support the new data version.

Overview of work done

  • update dynamodb terraform to add version d tables
  • rework how collection name/table info is handled in constants throughout all hydrocron modules
  • update unit tests

Overview of verification done

Unit tests pass

Overview of integration done

No integration tests yet as we don't have any version D data to test with yet.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@torimcd torimcd requested a review from nikki-t October 31, 2024 19:02
@torimcd torimcd changed the title Feature/issue 229 Feature/issue 229 - Create new database tables for version D collections Oct 31, 2024
Copy link
Collaborator

@nikki-t nikki-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I had one comment on table names but I don't think that we necessarily have to do anything at this point.

I think we had decided to hold off on merging until we had some version D data to work with in SIT. But we could merge this into develop and then perform the SIT testing on the combined database and API updates too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just trying to think out the impact of the table names. I don't think we want to change the existing ones as that would be really impactful - although I bet we could retire them after the switch to version D data. Do we want to differentiate between the two tables in a more generic way, not sure the best way to do this? Or should we plan to add a new table for each new version and delete the previous version that is no longer in use?

@torimcd torimcd marked this pull request as ready for review November 14, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new database tables for Version D collections
2 participants