Skip to content

Adding discord link and icon in the footer - resolves #2036 #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

samuil4
Copy link
Contributor

@samuil4 samuil4 commented May 31, 2025

Closes #2036

Motivation and context

  • Added new icon in the footer.
  • Had to add Discord icon as inline SVG as MUI lacks this Icon
  • Icon link point to new page -> https://discord.com/invite/nZAeCb9YzP
  • Added translation for the aria-label

Screenshots:

Before After
image image
  • Footer

Testing

Desktop and mobile - OK.

Steps to test

Scroll to the footer.

Affected urls

All that have the footer component visible

Environment

New environment variables:

None.

New or updated dependencies:

None

Copy link

github-actions bot commented May 31, 2025

✅ Tests will run for this PR. Once they succeed it can be merged.

@ani-kalpachka
Copy link
Member

Great enhancement! 🚀
Could you please remove target="_blank" and rel="noopener noreferrer" properties since the ExternalLink component already applies them?

@samuil4
Copy link
Contributor Author

samuil4 commented Jun 2, 2025

Done. Thanks for the review.

@ani-kalpachka ani-kalpachka added the run tests Allows running the tests workflows for forked repos label Jun 2, 2025
@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Jun 2, 2025
@ani-kalpachka ani-kalpachka merged commit df702a5 into podkrepi-bg:master Jun 2, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing link to discord server
2 participants