Draft
Conversation
sc0ttkclark
force-pushed
the
release/3.4.0
branch
2 times, most recently
from
8dc3511 to
d528df0
Compare
sc0ttkclark
force-pushed
the
release/3.4.0
branch
2 times, most recently
from
81f3cf6 to
89e8c96
Compare
sc0ttkclark
force-pushed
the
release/3.4.0
branch
from
5ef6d27 to
0c5a845
Compare
useEffect value-sync approach in repeatable DateTime, Currency, Text, and Number fields have been replaced with useRef. A previous fix for drag-and-drop reorder (including value in the React key) caused repeatable text fields to lose focus on every keystroke. Removing the value from the key fixed focus but regressed drag-and-drop for date/currency/number fields that maintain internal state. This replaces both approaches with useRef for persistent field IDs which associate with items during reorder. React tracks component instances without remounting, so text fields keep focus and fields keep their order.
sc0ttkclark
force-pushed
the
release/3.4.0
branch
from
b174178 to
db3f3ac
Compare
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
…e fields Signed-off-by: Scott Kingsley Clark <[email protected]>
sc0ttkclark
force-pushed
the
release/3.4.0
branch
from
98adbe9 to
6d7c202
Compare
Signed-off-by: Scott Kingsley Clark <[email protected]>
… checks and introduce ALL comparison variations Fixes #7272 Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
…tionship view Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
…ble ListItem Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
Signed-off-by: Scott Kingsley Clark <[email protected]>
sc0ttkclark
force-pushed
the
release/3.4.0
branch
from
b4e18f6 to
b635005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the included features so far: