Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android support #99

Closed
wants to merge 5 commits into from
Closed

Conversation

johankool
Copy link

No description provided.

@mbrandonw
Copy link
Member

Hi @johankool, sorry just getting around to looking at this.

But unfortunately we are not going to take such a PR. This is a massive change to the library by bringing in OpenCombine. We cannot force such a dependency on all of our downstream consumers.

The library does currently compile on Android, but that's because we simply omit all the code when compiling for Android since it is hidden behind a #if canImport(Combine). That is as far as we are willing to go in this library.

So, if you want to add the CI steps that would be fine. But we can't take the OpenCombine stuff.

@johankool
Copy link
Author

@mbrandonw Thanks for the headsup. And yes, that makes sense. I am not quite sure we'd even need it in the end as my end goal is to be able to compile TCA on Android and figured the first steps are to bring its dependencies over.

I'll close this PR and make a separate one for the CI steps.

@johankool johankool closed this Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants