-
Notifications
You must be signed in to change notification settings - Fork 176
Conversation
Code Climate has analyzed commit ed4b1a1 and detected 0 issues on this pull request. View more on Code Climate. |
|
||
thermal_vias: | ||
count: [2, 3] | ||
drill: 0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to enter µVia waters for this relatively large EP?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0.2mm is the standard drill size I recall being used throughout. You can see 3 existing definitions in dfn.yaml using it. Does something need to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, most are 0.2mm.
I tend to ask contributors for 0.3mm (although I forget sometimes) because 0.3mm is often the smallest mechanical hole cheap fabs will drill.
I figure our ThermalVias footprints are mostly used as ad hoc, better-than-nothing thermal management solutions, so 0.3mm seems to be a more reasonable default to me.
As far as I'm aware, most scripted footprints currently use 0.2mm for no other reason than that value being copied and pasted over and over again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be fixed globally? Perhaps if and when this repo is moved to GitLab? It seems rather unrelated to this one PR. Or are you requiring this change on all script updates to be merged starting now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, merging as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, even knowing about the bugs filed against this, and raising it in review, it went in anyway?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There has been no decision on Thermal via drills are needlessly small KiCad/kicad-footprints#2153
- This FP isn't completely broken but just perhaps less useful than it could be (and a slightly inconvenient FP is definitely better than nothing)
- As @evanshultz said, fixing this globally when the matter is settled is easy.
So, yes, it went in anyway. We can't keep everything on hold because there might be some marginal issue with it, especially if it's easily fixed afterwards.
https://www.analog.com/media/en/technical-documentation/data-sheets/4320fb.pdf#page=10
Footprint PR: KiCad/kicad-footprints#2226