Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Normalize path in sink_csv #17476

Merged

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Jul 7, 2024

Fixes #17473.

@coastalwhite coastalwhite changed the title fix(python): normalize path in sink_csv fix(python): Normalize path in sink_csv Jul 7, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Jul 7, 2024
Copy link

codecov bot commented Jul 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (ad836bd) to head (9de1a33).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17476      +/-   ##
==========================================
- Coverage   80.49%   80.49%   -0.01%     
==========================================
  Files        1483     1483              
  Lines      195010   195010              
  Branches     2781     2781              
==========================================
- Hits       156972   156969       -3     
- Misses      37527    37530       +3     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@etiennebacher
Copy link
Contributor

etiennebacher commented Jul 7, 2024

Hi, I had a question in another PR (#16869 (comment)) regarding whether paths should be normalized on the Rust or on the Python side. The other PR adds some implementation in Rust but you do this in Python, so I'm wondering which should be done.

@coastalwhite
Copy link
Collaborator Author

I think this change is so small, such that until the path normalisation is fully handled on the rust side, this does no harm.

@ritchie46 ritchie46 merged commit ccfacc8 into pola-rs:main Jul 8, 2024
15 of 17 checks passed
@coastalwhite coastalwhite deleted the fix-unnormalized-csv-path-17473 branch July 8, 2024 06:58
henryharbeck pushed a commit to henryharbeck/polars that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sink_csv fails when given a path with tilde
3 participants