-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add dtype to str.to_integer() #22239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
math-hiyoko
wants to merge
13
commits into
pola-rs:main
Choose a base branch
from
math-hiyoko:feature/#20567
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22239 +/- ##
=======================================
Coverage 80.77% 80.77%
=======================================
Files 1640 1640
Lines 235577 235629 +52
Branches 2714 2714
=======================================
+ Hits 190282 190327 +45
- Misses 44654 44661 +7
Partials 641 641 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Everything is ready now |
Also closes #11612. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a dtype option to str.to_integer(), limited to PolarsIntegerTypes. Each dtype corresponds to a call to the appropriate Rust from_str_radix implementation. The default type is pl.Int64.
Example
close #20567