-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
feat: Add dtype to str.to_integer() #22239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22239 +/- ##
==========================================
- Coverage 80.72% 80.71% -0.02%
==========================================
Files 1644 1644
Lines 221684 221719 +35
Branches 2786 2786
==========================================
- Hits 178957 178955 -2
- Misses 42064 42101 +37
Partials 663 663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Everything is ready now |
Also closes #11612. |
All checks are green; happy to rebase or tweak if needed. Thanks! |
Hi @orlp – gentle ping. |
fd75f00
to
2712138
Compare
Hi maintainers, Just a gentle reminder about this PR (#22239) — it’s been open for a couple of months now, CI is all green, and I’m happy to make any further tweaks if needed. I’d really appreciate it if someone could take a look when you get a chance. Thanks a lot! |
Sorry I missed your ping last week, I was on holiday. I will take a look today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :) Thanks for your contribution.
Thank you all for taking the time to review and approve this PR! |
This adds a dtype option to str.to_integer(), limited to PolarsIntegerTypes. Each dtype corresponds to a call to the appropriate Rust from_str_radix implementation. The default type is pl.Int64.
Example
close #20567