Skip to content

feat: 上报监控及调用链校验失败不抛异常 #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 19, 2024
Merged

feat: 上报监控及调用链校验失败不抛异常 #521

merged 11 commits into from
Jun 19, 2024

Conversation

andrewshan
Copy link
Member

@andrewshan andrewshan commented Jun 18, 2024

@andrewshan andrewshan changed the title feat: 上报监控及调用链失败不抛异常 feat: 上报监控及调用链校验失败不抛异常 Jun 19, 2024
Copy link
Member

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

注册和心跳检验端口号的地方,不抛异常是否不合适?

@andrewshan
Copy link
Member Author

注册和心跳检验端口号的地方,不抛异常是否不合适?

注册和心跳相关接口,不涉及这个校验

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 18 lines in your changes missing coverage. Please review.

Project coverage is 23.00%. Comparing base (2824767) to head (c1d81a5).
Report is 21 commits behind head on main.

Files Patch % Lines
...ava/com/tencent/polaris/client/api/BaseEngine.java 0.00% 9 Missing ⚠️
...m/tencent/polaris/client/util/CommonValidator.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #521      +/-   ##
============================================
- Coverage     24.78%   23.00%   -1.79%     
- Complexity      624      711      +87     
============================================
  Files           196      273      +77     
  Lines          8621    10397    +1776     
  Branches       1115     1300     +185     
============================================
+ Hits           2137     2392     +255     
- Misses         6228     7708    +1480     
- Partials        256      297      +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SkyeBeFreeman SkyeBeFreeman merged commit 241fad2 into polarismesh:main Jun 19, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants