Skip to content

Commit

Permalink
Simplify Dawid's PR (#87): Refer directly to signatures file if not j…
Browse files Browse the repository at this point in the history
…arred (this makes logging cleaner).
  • Loading branch information
uschindler committed Nov 9, 2015
1 parent 229d9e0 commit 44fd341
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,6 @@ private URL createJarUrl(File f, String jarPath) throws MalformedURLException {
return new URL(jarBaseUrl, encodeUrlPath(jarPath));
}

private URL createFileUrl(File f, String relativePath) throws MalformedURLException {
return new File(f, relativePath).toURI().toURL();
}

@Override
public void execute() throws MojoExecutionException {
final Logger log = new Logger() {
Expand Down Expand Up @@ -373,7 +369,9 @@ public void info(String msg) {
final File f = resolveSignaturesArtifact(artifact);
if (artifact.path != null) {
if (f.isDirectory()) {
sigUrls.add(createFileUrl(f, artifact.path));
// if Maven did not yet jarred the artifact, it returns the classes
// folder of the foreign Maven project, just use that one:

This comment has been minimized.

Copy link
@dweiss

dweiss Nov 10, 2015

Contributor

It's called the "reactor" in Maven parlance (I think). :)

This comment has been minimized.

Copy link
@uschindler

uschindler Nov 10, 2015

Author Member

I would call it Fukushima!

sigFiles.add(new File(f, artifact.path));
} else {
sigUrls.add(createJarUrl(f, artifact.path));
}
Expand Down

0 comments on commit 44fd341

Please sign in to comment.