Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For static method calls and field accesses do not look into superclasses #238

Merged
merged 11 commits into from
Nov 7, 2023
+139 −6
Merged

For static method calls and field accesses do not look into superclasses #238

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5de7f4e
For static method calls and field accesses do not look into superclas…
uschindler Nov 6, 2023
910851d
Also look into superclasses now, this is correct way to handle it
uschindler Nov 6, 2023
f14c90f
restore constructor exact check
uschindler Nov 6, 2023
a6e1dd0
Restore logic for fields
uschindler Nov 6, 2023
806c609
Fix recursion problem with visitSelf=true
uschindler Nov 7, 2023
fbb29ef
Add test
uschindler Nov 7, 2023
2305196
add comments
uschindler Nov 7, 2023
fd9e2ee
enforce failure on missing classes
uschindler Nov 7, 2023
f295e40
Improve test and add virtual methods and fields to test; also include…
uschindler Nov 7, 2023
9716c54
Remove logDoesntContain as it is not useful, combination of "X error(…
uschindler Nov 7, 2023
a1fcf60
Add line number checks for virtual calls
uschindler Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
enforce failure on missing classes
@uschindler
uschindler committed Nov 7, 2023
commit fd9e2ee8f73a1479144027adf9c82a102e7f3a16
2 changes: 1 addition & 1 deletion src/test/antunit/TestStaticVsVirtual.xml
View file
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@

<target name="testStatic">
<au:expectfailure expectedMessage="Check for forbidden API calls failed, see log">
<forbiddenapis failOnMissingClasses="false">
<forbiddenapis>
<fileset file="Java7StaticVsVirtual*.class"/>
java.util.BitSet#valueOf(**) @ Forbidden static method
</forbiddenapis>