Skip to content

Commit

Permalink
Fix node v22 testing compatibility w/ dev bump (#6024)
Browse files Browse the repository at this point in the history
* Fix node v22 testing compatibility

* uncomment tests

* revert to using assert

* Bump dev
  • Loading branch information
TarikGul authored Nov 10, 2024
1 parent 61a6fbd commit 7b41b63
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 22 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/pr-any.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
# This will default to using v20 so that CI will pass.
# ref: https://github.com/polkadot-js/api/issues/6017
node-version: 'lts/iron'
node-version: 'lts/*'
- uses: denoland/setup-deno@v1
with:
deno-version: v1.42.x
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/push-master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ jobs:
token: ${{ secrets.GH_PAT_BOT }}
- uses: actions/setup-node@v4
with:
# This will default to using v20 so that CI will pass.
# ref: https://github.com/polkadot-js/api/issues/6017
node-version: 'lts/iron'
node-version: 'lts/*'
- name: ${{ matrix.step }}
run: |
yarn install --immutable
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"test:one": "polkadot-dev-run-test --env node"
},
"devDependencies": {
"@polkadot/dev": "^0.81.2",
"@polkadot/dev": "^0.82.1",
"@polkadot/typegen": "workspace:packages/typegen",
"@types/node": "^22.7.5"
},
Expand Down
30 changes: 15 additions & 15 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -536,34 +536,34 @@ __metadata:
languageName: unknown
linkType: soft

"@polkadot/dev-test@npm:^0.81.2":
version: 0.81.2
resolution: "@polkadot/dev-test@npm:0.81.2"
"@polkadot/dev-test@npm:^0.82.1":
version: 0.82.1
resolution: "@polkadot/dev-test@npm:0.82.1"
dependencies:
jsdom: "npm:^24.0.0"
tslib: "npm:^2.7.0"
checksum: 10/1028c3b1804567128f1cc796df2285827bb8d9d54afee8c81f28821d2205e7f4522bd9659eb2e7645a080568d43b394279db12b1c2debdc447d5567317b7c2fc
checksum: 10/669690400183b33187a526c9b5d5427957e30ace31635975a7b20d2cbfc4bda002f9ea71bde87e9e37d8153bc5b56b7d6059b52a3fe973fce6023595a438e3df
languageName: node
linkType: hard

"@polkadot/dev-ts@npm:^0.81.2":
version: 0.81.2
resolution: "@polkadot/dev-ts@npm:0.81.2"
"@polkadot/dev-ts@npm:^0.82.1":
version: 0.82.1
resolution: "@polkadot/dev-ts@npm:0.82.1"
dependencies:
json5: "npm:^2.2.3"
tslib: "npm:^2.7.0"
typescript: "npm:^5.5.4"
checksum: 10/cb25e9523cbad5029f7e149135aa003286d9c907677902e6a1ffe4a905d6c31f6c88a647b3be0e51b09e62528fca2a3121f12a748942ecd6eccefd8da1eb3369
checksum: 10/a7ac2a614bf93e2406d65e153f110d55c8b2a7eaf44672622586dd2f9bc0d6e4a36e0a05a66654370a1c66061a7668f0df93151142c7d9a281d56df4827c9418
languageName: node
linkType: hard

"@polkadot/dev@npm:^0.81.2":
version: 0.81.2
resolution: "@polkadot/dev@npm:0.81.2"
"@polkadot/dev@npm:^0.82.1":
version: 0.82.1
resolution: "@polkadot/dev@npm:0.82.1"
dependencies:
"@eslint/js": "npm:^8.56.0"
"@polkadot/dev-test": "npm:^0.81.2"
"@polkadot/dev-ts": "npm:^0.81.2"
"@polkadot/dev-test": "npm:^0.82.1"
"@polkadot/dev-ts": "npm:^0.82.1"
"@rollup/plugin-alias": "npm:^5.1.0"
"@rollup/plugin-commonjs": "npm:^25.0.7"
"@rollup/plugin-dynamic-import-vars": "npm:^2.1.2"
Expand Down Expand Up @@ -628,7 +628,7 @@ __metadata:
polkadot-exec-rollup: scripts/polkadot-exec-rollup.mjs
polkadot-exec-tsc: scripts/polkadot-exec-tsc.mjs
polkadot-exec-webpack: scripts/polkadot-exec-webpack.mjs
checksum: 10/304d2e1e5a5669b0888026fd0fb3e82dba75e1a85c9c40481d0832b072bac9ba6f9e9755db4bdce4c2aa10c631ef7f4fba84114a1b6490d25aa5b4f6dff65299
checksum: 10/5739c27e09db8bf09582f1016d7db83ca6c09eb9ece9b4c3df05073670dccb5ecb05464e26c4aaea846354dc6cfcea26f6dd727fc2c42bc8e04e04f9319e5321
languageName: node
linkType: hard

Expand Down Expand Up @@ -7945,7 +7945,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "root-workspace-0b6124@workspace:."
dependencies:
"@polkadot/dev": "npm:^0.81.2"
"@polkadot/dev": "npm:^0.82.1"
"@polkadot/typegen": "workspace:packages/typegen"
"@types/node": "npm:^22.7.5"
languageName: unknown
Expand Down

0 comments on commit 7b41b63

Please sign in to comment.