fix for new version of udemy #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, I have zero experience with Python and I needed to use your script. So after few minutes googling I installed all dependencies. So I extended your README to help others
Update README
Added Exception type at the urllib import statement. raw_input() was replaced by input() in Python 3, so NameError exception will be raised in Python 3 and input() would be used instead.
Improved Python 3 compatibility.
Enable download of HD version of lectures
Add output dir command line argument
…ning when manually installing.
…to unconditional-master Conflicts: udemy-dl.py
setup.py fixes for default permissions
Expanded the README
temporary solution for curl
Added .encode('utf-8') for filename to avoid UnicodeEncodeError
…ubinznz-patch-1
Fixes #53, fixes #54, fixes #56
"CA cert error fix based on #48 and #57"
abhishek0494
approved these changes
Jun 20, 2018
|
Hello @pombredanne will you merge the fixes ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.