fix: put back context.mounted check #558
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We see a small number of error reports caused by unmounted context at the time
FToast.removeCustomToastis called.Scenario
We have a Flutter app integrated into the native app and this is what happens:
removeCustomToaston timer to close the toast that is shown_showOverlayis called that tries to get theOverlay, but the context is unmountedThe straightforward fix would be to just check whether the context is mounted and handle this edge case. However, I see that there is already code in place to do that, but it is commented out by this commit 5c1dd53
Do you have any context why it was commented out and whether it's still relevant?