-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat with libcosmic #12
Open
13r0ck
wants to merge
15
commits into
main
Choose a base branch
from
libcosmic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pop-os/libcosmic#110 needs to be merged, then I can change the libcosmic dep to github, then this will pass CI. |
Requires adding the libcosmic feature in Cargo.toml ``` cosmic-time = { version = 1.2.3, features = ["libcosmic"] } ```
13r0ck
force-pushed
the
libcosmic
branch
4 times, most recently
from
June 5, 2023 19:52
d91f47d
to
3db4552
Compare
Particulatly animations that are triggered from an interaction, and the animation needs to be passed thtough a message.
13r0ck
force-pushed
the
libcosmic
branch
5 times, most recently
from
June 6, 2023 00:06
efe214b
to
211c0be
Compare
Libcosmic needs to correctly expose a subscription to the display's refresh rate.
Reduces code duplication and makes cosmic-time easier to use with iced integrations where `subscriptions` might not be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires adding the libcosmic feature in Cargo.toml
Requires pop-os/libcosmic#110