wayland: Fix handling of discrete/value120 scroll events #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Should test `!= 0`, not `> 0`; can scroll in either direction - Test both vertical and horizontal - Use `value120` scroll if present (in which case, discrete is 0) I guess events should really have both line and pixel scroll, since some widgets want to use the pixel scroll values for input devices that have both? But I guess winit and Iced both need to be changed for that...
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Oct 7, 2025
Combined with pop-os/iced#244, discrete value120 scrolling works better.
|
|
wash2
approved these changes
Oct 8, 2025
ids1024
added a commit
to pop-os/libcosmic
that referenced
this pull request
Oct 9, 2025
Update iced with pop-os/iced#244.
ids1024
added a commit
to pop-os/libcosmic
that referenced
this pull request
Oct 9, 2025
Update iced with pop-os/iced#244.
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Oct 9, 2025
Combined with pop-os/iced#244, discrete value120 scrolling works better.
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Oct 9, 2025
Combined with pop-os/iced#244, discrete value120 scrolling works better.
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Oct 13, 2025
Combined with pop-os/iced#244, discrete value120 scrolling works better.
ids1024
added a commit
to pop-os/cosmic-workspaces-epoch
that referenced
this pull request
Oct 13, 2025
Combined with pop-os/iced#244, discrete value120 scrolling works better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!= 0, not> 0; can scroll in either directionvalue120scroll if present (in which case, discrete is 0)I guess events should really have both line and pixel scroll, since some widgets want to use the pixel scroll values for input devices that have both? But I guess winit and Iced both need to be changed for that...