Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): be consistent in getting cache path #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rmsthebest
Copy link

very minor fix, but it was a bit inconsistent in following xdg dirs.
I also slightly changed wording in the error messages as they were a bit confusing to me when I was seeing them.

@jacobgkau jacobgkau requested review from a team December 26, 2023 16:21
@jacobgkau jacobgkau self-assigned this Dec 26, 2023
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes the recent file to be created in ~/.local/state/pop-launcher/ instead of ~/.cache/pop-launcher/. It still seems to be functioning as expected. Reviewing documentation and discussion about the difference between cache and state in the XDG spec, I think state is the right place for it to go.

This will effectively reset everyone's recent state when they install this update since the file is created from scratch in the new location (with the old one continuing to sit around in perpetuity). I don't think this is a critical issue, but it would be nice if there was some way to not have to do that... e.g. have some code to move the file to the new location, which we could remove after a few months or something.

Thoughts from anyone else if that's feasible or worth the hassle?

@jacobgkau
Copy link
Member

If we're going to make this change (without migrating the file), perhaps the 24.04 upgrade would be a good time to do it.

To ask again, would transition code to check for the old location and copy it to the new one be feasible?

@mmstick
Copy link
Member

mmstick commented Sep 6, 2024

It should move the file automatically when found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants