-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposed production-level config for humans #97
Conversation
@chriscrsmith,
|
also you want the "num_msmc_iterations" to be at least 20 |
dfe and annotations list need to be the same length
|
For 'replicates' I think it should be more than 3. Not sure what an upper limit is ... maybe 10 or at least 20? |
Thanks @stsmall . Ok what do you think of the new version? I left reps=3 until we get input from others. 20 sounds like too many to me |
The plots use seeds (reps) to create CI ribbons. 3 reps will just be noisy. IDK if 20 is too many or not enough, I just picked a number. Since it runs in parallel w/ the reps, shouldnt be too much a slow down to do more, right? We could always add more later, but then would have to rerun the n_t, dfe pipelines on the full dataset. |
Otherwise it looks good. :) |
gotcha, the ribbons. 20 reps sounds good |
i'm a bit concerned about the compute cost of 20 reps up front. The way these runs go, we almost always have to rerun it. |
If it's already the longest running part of the analysis, I think let's leave for now, update later as needed? |
see new commit: changed genetic map, deleted some unused parameters I have not done a full run yet, but if I turn on scaling it seems to get off the ground ok. |
There was some talk in the tuesday meeting about potentially doing the Papuan demographic model. What does everyone think? |
That would be a flex. :-) I guess we'd assume the DFE was the same in Denisova and Neanderthal as modern humans. We'd lose the easy comparison with the previous paper, but if we run and include the neutral analysis here, that's no problem. |
Say, @chriscrsmith - could you clarify what exactly is being proposed? Like, is there going to be just one demographic model? Or, more than one? And, what DFE(s)? |
Demog.
DFEs
|
I'm still a bit fuzzy here - are we deciding which single model to run, or are we deciding between having 1 or 2 models? Or what? And, concretely, what goes in the paper - is this the demographic model(s) that'll be used for both (a) inferring DFEs and (b) the effect of selection on demographic inference? The same one(s) for both? |
Demog.
DFEs
|
I imagined at least running the same demographic model from the previous paper.
I think that makes sense. |
I agree about using the same model as in the last paper. There is nothing special (besides being an early model and thus jumping to our minds more easily?) about OutOfAfrica_3G09. I don't have a good sense about whether we've got room for results about more than one model - that depends on what figures we want? |
Updated the PR to delete the human model we've been using, so it's now replaced with the model from the previous paper. Here's the relevant post about our plan for the paper: #8 |
Thanks for finding the outline! =) So, current proposal is to just have one model? That seems fine to me, really - unless there's a reason to think that methods might behave differently under some methods than others? But, I guess if we're going to look at different scenarios I'd much rather look at different speices than just different human models. So: I agree! |
In the meeting just now we decided we can merge this. |
In meeting just now agreed this looks good, minus the Gamma_H17 dfe. |
@chriscrsmith says merge! |
Soliciting feedback on the choice of settings in the proposed config. This will be what @lntran26 and I use for the hopefully final simulations in humans without scaling.
Notes: