Improve behaviour of idle_in_transaction_session_timeout#1155
Open
davibe wants to merge 2 commits intoporsager:masterfrom
Open
Improve behaviour of idle_in_transaction_session_timeout#1155davibe wants to merge 2 commits intoporsager:masterfrom
davibe wants to merge 2 commits intoporsager:masterfrom
Conversation
5b7195d to
469e9df
Compare
2d36493 to
ac5f883
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1133
When PostgreSQL kills a connection due to idle_in_transaction_session_timeout, two issues could occur:
Changes:
src/connection.js:
src/index.js:
This ensures txSql always fails with CONNECTION_CLOSED when the underlying connection is killed, regardless of whether the connection object later reconnects for other pool queries.