test: fix flaky decorator test in Firefox#2400
Merged
christianhg merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Contributor
📦 Bundle Stats —
|
| Metric | Value | vs main (ef2c721) |
|---|---|---|
| Internal (raw) | 753.2 KB | - |
| Internal (gzip) | 141.5 KB | - |
| Bundled (raw) | 1.36 MB | - |
| Bundled (gzip) | 304.4 KB | - |
| Import time | 99ms | -1ms, -0.6% |
@portabletext/editor/behaviors
| Metric | Value | vs main (ef2c721) |
|---|---|---|
| Internal (raw) | 467 B | - |
| Internal (gzip) | 207 B | - |
| Bundled (raw) | 424 B | - |
| Bundled (gzip) | 171 B | - |
| Import time | 6ms | +0ms, +1.6% |
@portabletext/editor/plugins
| Metric | Value | vs main (ef2c721) |
|---|---|---|
| Internal (raw) | 2.5 KB | - |
| Internal (gzip) | 910 B | - |
| Bundled (raw) | 2.3 KB | - |
| Bundled (gzip) | 839 B | - |
| Import time | 12ms | +0ms, +1.0% |
@portabletext/editor/selectors
| Metric | Value | vs main (ef2c721) |
|---|---|---|
| Internal (raw) | 60.2 KB | - |
| Internal (gzip) | 9.4 KB | - |
| Bundled (raw) | 56.7 KB | - |
| Bundled (gzip) | 8.6 KB | - |
| Import time | 10ms | +0ms, +2.1% |
@portabletext/editor/utils
| Metric | Value | vs main (ef2c721) |
|---|---|---|
| Internal (raw) | 24.2 KB | - |
| Internal (gzip) | 4.7 KB | - |
| Bundled (raw) | 22.2 KB | - |
| Bundled (gzip) | 4.4 KB | - |
| Import time | 9ms | +0ms, +0.4% |
🗺️ . · ./behaviors · ./plugins · ./selectors · ./utils · Artifacts
Details
- Import time regressions over 10% are flagged with
⚠️ - Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.
christianhg
force-pushed
the
fix/flaky-decorator-test-firefox
branch
from
a6bd84a to
213386e
Compare
christianhg
force-pushed
the
fix/flaky-decorator-test-firefox
branch
from
213386e to
77db11e
Compare
Remove unreliable ArrowUp navigation and typing step. The test now verifies the split result directly: after pressing Enter before a decorated word, both the new empty block and the original block retain the decorator.
christianhg
force-pushed
the
fix/flaky-decorator-test-firefox
branch
from
77db11e to
b9006c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Splitting block before decorator" scenario uses
{ArrowUp}to navigate to the previous block after pressing Enter. In headless Firefox CI, the ArrowUp selection change can be slow or unreliable, causing the test to proceed before the cursor has actually moved. This results in "bar" being inserted into the wrong block.Replace ArrowUp with a programmatic
the caret is put after ""which targets the empty first block directly. The test is verifying decorator preservation across block splits, not arrow key navigation.