Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Quirion dividend import in USD #3475

Closed
wants to merge 1 commit into from
Closed

Fix Quirion dividend import in USD #3475

wants to merge 1 commit into from

Conversation

buchen
Copy link
Member

@buchen buchen commented Aug 3, 2023

Issue: #3474

@christen90 @buchen
Fix Quirion dividend import in USD
5f7d8fd 
Issue: #3474
Signed-off-by: Christian Kaufmann <[email protected]>
[rebased to master]
Signed-off-by: Andreas Buchen <[email protected]>
@buchen
Copy link
Member Author

buchen commented Aug 3, 2023

@christen90 - apparently, I had to create a new pull request. Please have a look at your change - I might have mangled up something... 🙄

@buchen buchen mentioned this pull request Aug 3, 2023
Closed
@Nirus2000
Copy link
Member

I don't understand this pull request at all.
What is changed here and why are useless parts inserted?

@Nirus2000 Nirus2000 added the pdf label Aug 5, 2023
@Nirus2000 Nirus2000 requested review from Nirus2000 and removed request for Nirus2000 August 5, 2023 05:39
@Nirus2000 Nirus2000 assigned buchen and unassigned Nirus2000 Aug 5, 2023
@buchen
Copy link
Member Author

buchen commented Aug 5, 2023

I let @christen90 comment on the details.

But what I can see is that the "Dividende04.txt" example cannot be imported without the changes to the extractor.

Failures:
  QuirinPrivatbankAGPDFExtractorTest.testDividende04:592 Buchungswährung USD passt nicht zu Kontowährung EUR
26.07.2023 Dividende USD 1,57 iShsIII-MSCI EM Sm.Cap U.ETF Registered Shares o.N. Dividende04.txt
Expected: is <OK>
     but: was <ERROR>

My reading of the change is: like many other sections that have different format (there are already many Format01 and Format02 methods), there apparently is also a differences is the formatting of the "taxes sections".

What is changed here and why are useless parts inserted?

Can you specify what you mean by "useless parts"?

@buchen buchen assigned Nirus2000 and unassigned buchen Aug 5, 2023
@buchen buchen closed this Aug 5, 2023
@buchen buchen deleted the pr/3474 branch August 5, 2023 08:40
@buchen buchen mentioned this pull request Aug 5, 2023
Closed
@buchen
Copy link
Member Author

buchen commented Aug 5, 2023

Let's continue here: #3482

@portfolio-performance portfolio-performance locked and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Nirus2000 Nirus2000

Labels
pdf
Projects
Importer (PDF, CSV, IB-Flex)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@buchen @Nirus2000 @christen90