Skip to content

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented Sep 1, 2024

For many people, ticker is more familiar than security name/title (this
is especially true for funds). toString() is used e.g. in dropdown boxes
for security selection. So, if a corresponding preference is enabled by
user, include ticker in the display string.

If ticker symbol is not available, or matches the security name, toString()
will return just "name", as before.

Checkbox setting in "Formatting Preferences" pages to either include/prefer
ticker symbol when identifying security to user, or use just security name,
as before. The motivation is that some (many?) people are actually more
familiar with ticker symbols used on popular exchanges, rather than security
names, which is especially true in the case of funds. However, other people
may be already used to just a security name be presented by PP, so make the
setting configurable.

This change only implement preferences UI and API accessors, actual
implementation of the "Prefer 'symbol'" setting in various places of PP UI
will happen in follow-up commits.
For many people, ticker is more familiar than security name/title (this
is especially true for funds). toString() is used e.g. in dropdown boxes
for security selection. So, if a corresponding preference is enabled by
user, include ticker in the display string.

If ticker symbol is not available, or matches the security name, toString()
will return just "name", as before.
@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 1, 2024

This is updated version of #4183, based on (ongoing) discussion in #4182 . A checkbox preference Prefer 'symbol' to identify securities is added, by default the behavior is the same as before, but if the pref is checked, SYMBOL (name) will be used.

@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 1, 2024

Example of security selection dropdown before the setting activation:
Screenshot at 2024-09-01 16-15-27

The setting activated:
Screenshot at 2024-09-01 16-15-48

Example of security selection dropdown after the activation:
Screenshot at 2024-09-01 16-16-19

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 3, 2024

@buchen : What do you think about this solution?

@buchen
Copy link
Member

buchen commented Oct 3, 2024

What do you think about this solution?

I am just looking at it.

I'll push an alternative implementation that
a) stores the property in the file (in order to re-use it across installation and on the mobile app)
b) allows to pick other identifier as well (because ticker is a special case)

I am not done yet. For example the sorting is not correct yet (see also your screenshot above).
And the label and translations are missing.

But as I will break for lunch soon, I will push a draft pull request and would appreciate if you can test it.

@pfalcon
Copy link
Contributor Author

pfalcon commented Oct 4, 2024

@buchen :

But as I will break for lunch soon, I will push a draft pull request and would appreciate if you can test it.

Thanks! Commented at #4265 (comment)

@buchen
Copy link
Member

buchen commented Oct 12, 2024

Superseeded by #4265

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants