-
Notifications
You must be signed in to change notification settings - Fork 704
Security: Allow toString() be (in general) "ticker (name)" #4211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security: Allow toString() be (in general) "ticker (name)" #4211
Conversation
pfalcon
commented
Sep 1, 2024
Checkbox setting in "Formatting Preferences" pages to either include/prefer ticker symbol when identifying security to user, or use just security name, as before. The motivation is that some (many?) people are actually more familiar with ticker symbols used on popular exchanges, rather than security names, which is especially true in the case of funds. However, other people may be already used to just a security name be presented by PP, so make the setting configurable. This change only implement preferences UI and API accessors, actual implementation of the "Prefer 'symbol'" setting in various places of PP UI will happen in follow-up commits.
For many people, ticker is more familiar than security name/title (this is especially true for funds). toString() is used e.g. in dropdown boxes for security selection. So, if a corresponding preference is enabled by user, include ticker in the display string. If ticker symbol is not available, or matches the security name, toString() will return just "name", as before.
@buchen : What do you think about this solution? |
I am just looking at it. I'll push an alternative implementation that I am not done yet. For example the sorting is not correct yet (see also your screenshot above). But as I will break for lunch soon, I will push a draft pull request and would appreciate if you can test it. |
@buchen :
Thanks! Commented at #4265 (comment) |
Superseeded by #4265 |