Skip to content

Conversation

pfalcon
Copy link
Contributor

@pfalcon pfalcon commented Sep 1, 2024

Some views in the app allow to select multiple securities, so allow to
perform operations on all of them. Without such support, behavior can
be confusing, for example, currently a user can select multiple securities
in "Securities" view, and choose "Update quotes (selected)" via main menu,
but only one will be actually updated.

Some views in the app allow to select multiple securities, so allow to
perform operations on all of them. Without such support, behavior can
be confusing, for example, currently a user can select multiple securities
in "Securities" view, and choose "Update quotes (selected)" via main menu,
but only one will be actually updated.
@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 1, 2024

@buchen : I believe in one of your comments here in the issues I saw your comment (was awhile, can't point to now) that supporting multiple selection is somehow challenging. Caught my attention because was one of the initial changes I did. This adds infra for multiple selection, and then specifically implements it for "Update quotes (selected)". Going thru the entire app and making sure it's consistently supported is a different matter of course. Probably why it sat in my fork for awhile. I guess it's better to land this initial support, then none at all.

@pfalcon
Copy link
Contributor Author

pfalcon commented Sep 1, 2024

that supporting multiple selection is somehow challenging.

Here it is: #1499 (comment)

@buchen buchen merged commit 3b9a345 into portfolio-performance:master Sep 3, 2024
2 checks passed
@buchen
Copy link
Member

buchen commented Sep 3, 2024

I agree. Not sure what made me write the comment 🤔

buchen added a commit that referenced this pull request Sep 7, 2024
buchen added a commit that referenced this pull request Sep 7, 2024
@myrdd
Copy link
Contributor

myrdd commented Sep 24, 2024

Thanks for the PR. I think we should update the command.updateQuotesCurrentSecurity.name text from singular to plural (”selected securities“):

command.updateQuotesCurrentSecurity.name = Update &quotes (selected security)

This also needs to be changed in all translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants