adds ingoing, outgoing transfer and mark interest bookings in AccountStatements as NonImportable #4214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marks german interest payments in account statement as nonimportable
Nirus2000
requested changes
Sep 13, 2024
| t.setDateTime(asDate(v.get("date"))); | ||
| t.setAmount(asAmount(v.get("amount"))); | ||
| t.setCurrencyCode(asCurrencyCode(v.get("currency"))); | ||
| v.getTransactionContext().put(FAILURE, Messages.MsgErrorTransactionTypeNotSupported); |
There was a problem hiding this comment.
Hello @christen90
Thank you for this pull request.
Unfortunately I don't see a test for this change (FAILURE), why this line is added.
Can you add a test case that makes this change plausible?
Regards
Alex
…Format01 modifying test cases to check for error messages
Nirus2000
requested changes
Sep 14, 2024
| assertThat(results, hasItem(interest(hasDate("2023-04-01"), hasAmount("EUR", 0.01), // | ||
| hasSource("Kontoauszug05.txt"), hasNote(null)))); | ||
| assertThat(results, hasItem(withFailureMessage( // | ||
| Messages.MsgErrorTransactionTypeNotSupported, // |
There was a problem hiding this comment.
Hello @christen90
I understand the reason (interests), but we should issue a different message here, which could possibly also be used for other PDF importers.
I could imagine the following message:
MsgErrorTransactionAlternativeDocumentRequired = "Die Buchung wird mit diesem Dokument nicht verarbeitet. Ihre Bank oder Ihr Broker stellt ein anderes Dokument dafür zur Verfügung."
MsgErrorTransactionAlternativeDocumentRequired = "This document does not process the booking. Your bank or broker will provide a different document for this purpose."
Please change the error message and add the missing translations via deepl.com.
It is also better if you adjust the title of the pull request to make it easier to understand later.
Regards
Alex 😃
christen90
changed the title
- UTF8 upload error in translation file - Add some source - Fix test case as similare german transaction
Nirus2000
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi together,
this PR adds incoming, outgoing transfer
It also marks german interest payments in account statement as nonimportable
reason: tax amount is not included in account statements. interest transactions can be imported via specific document.
In my case there were two bookings (Geldmarkt Dividende and Cash Zinsen) in Abrechnung-Zinsen-document.
Importing both (Kontoauszug and Abrechnung Zinsen) was causing that Booking gets imported twice. Once the seperate dividend and interest with the exact amount of tax and the other one from account statement including just the sum. Resulting in a wrong saldo at the end.
BR Christian