Improve TradeRepublic PDF Importer #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for interest transaction with the identifiying line: "IBAN BUCHUNGSDATUM GESAMT"
MonkeySon
force-pushed
the
traderepublic_interest_fix
branch
from
ce43361
to
929c78f
Compare
|
Done... 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this pull request improves the TradeRepublic PDF importer by adding support for an additional type of interest transaction pdf.
It is contains the following identifying line, which was not supported previously:
"IBAN BUCHUNGSDATUM GESAMT"
Due to how PDFs with "ABRECHNUNG ZINSEN" are currently handled, a change was required in both
addTaxesStatementTransaction()andaddInterestStatementTransaction(). When only added to one of these, the parse in the other function would fail.BR,
MonkeySon