Support short selling gain calculation #4891
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #4890 to support short selling gain calculation, please only accept it after you approve that PR.
Short selling meaning selling anything you don't own right now while in the future this might either default (you keep all the money) or result in covering up by cash or buy up stocks as needed.
The action of short selling should be calculated as a capital gain (and taxed like that).
The aim of this PR is to fix the CapitalGain calculations and Cost calculation so that it doesn't treat short selling as negative unrealized capital income, it should treat it as a positive realized capital income instead.