-
Notifications
You must be signed in to change notification settings - Fork 704
Linux Pie Charts #5004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Linux Pie Charts #5004
Conversation
I tested in on Linux. Interesting: I get to see the pie charts in the taxonomy, but only if that is the initial view to be shown. If the taxonomy view opens with something else, then I see a small (I assume 50 by 50 pixel) thing and then an empty screen. |
BTW, that fits to the behavior that @hendrikm78 reported:
|
I tested it on macOS and Windows - there the scripts continue to work as expected. I think we can merge this, but I think the default on Linux should still be the SWT charts |
Does this initial vs non initial behaviour happens for both charts, or only for the donut chart, and flare is working correctly unconditionally all the time ? |
Only for the pie charts (holdings and donut). The flare chart seems to work all the time. |
This is how it looks now (I merged it with fbe8eab). You if one opens the donut the first time around, there is a small square of labels (I assume the 50 by 50). And then the chart is gone. If the chart is the default view to be opened for this taxonomy, then it is shown: Bildschirmaufnahme.2025-10-04.um.07.42.26.mp4 |
It is great then if it is an improvement for Linux for the Flare. It is a bit puzzling that the behaviour is different between those two charts, while the implementation seems quite similar. I wonder if there is a small side effect after all on Windows. I think there a visible one frame flicker when changing the accounts or the option "with/without Unclassified", "with/without securities level" ? On the Holdings, the change of selected accounts seems smoother. |
To be honest, I only briefly tested on Windows with this change. You mean there is now additional flicker on Windows when applying a "filtering options" such as "with/without unclassified"? I am not sure if that is new. If the file changes (new prices, new filter), I need to reload the HTML page. And for one frame, it renders an empty page. One could get around this - maybe - by triggering a method to update the pie chart. I haven't tried. I find it super hard to develop this because I could not find a debug console for the embedded browser. |
I am not sure if this is new either to be honest, I can double check on an older version. I took a video where we see the two behaviors :
*at the end of the video we can see it is here too. But it is not really reproductible and I think quite rare there. Enregistrement.7.mp4I agree this seems complicated while it is only a very small topic. |
Hello, this is just a draft POC from @hendrikm78 proposition here : #2719 (comment)
I do not have Linux myself, but as per the comments in the linked discussion, it seems this is fixing the "sunburst" pie chart, but not fixing the "donut" pie chart.
So this seems promising, I think this is worth a bit of visibility, in case Linux contributors want to further investigate.
On my side, both "sunburst" and "donut" pie chart keep functioning as intended on Windows 11.
If this goes somewhere, the contributor is hendrikm78, not me.