Create new CLAUDE-IMPORTER.md and CONTRIBUTING.md #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nirus2000
force-pushed
the
Create-new-CLAUDE-IMPORTER.md-and-CONTRIBUTING.md
branch
2 times, most recently
from
c322a88 to
3436b85
Compare
|
How do you tell Claude Code to use these instructions? (I am asking because to my knowledge claude is reading CLAUDE.md and I am wondering how to organize this best) |
|
Full generatet with Claude... --> Result --> #5037 1.) I create the PDF debug in the test folder. I write in the console follow command: Read and apply all rules, instructions, workflows, and best practices from 3.) I tell him that there is a new PDF debug with [NEWPDF-DEBUG].txt and that he should process it via [PDF-IMPORT-NAME]. 4.) Run ... |
Nirus2000
force-pushed
the
Create-new-CLAUDE-IMPORTER.md-and-CONTRIBUTING.md
branch
2 times, most recently
from
ff139d5 to
0ea8e59
Compare
Improve CLAUDE-IMPORTER.md with comprehensive PDF extractor guidance ## Updates Made: ### Architecture & Core Components - Simplified PDF-Import Architecture Overview with clearer process flow - Updated Core Classes documentation with accurate descriptions - Revised Key Entry Points to focus on PDF importer development essentials - Removed UI integration references to maintain focus ### Tax & Fee Processing - Replaced complex tax patterns with standard BaaderBankPDFExtractor approach - Added proper `addTaxesSectionsTransaction()` and `addFeesSectionsTransaction()` method documentation - Documented use of `processTaxEntries()` and `processFeeEntries()` utilities - Removed TaxAmountTransactionHelper references per standard practices ### Test Documentation - Enhanced test assertion structure with complete standard assertions - Fixed WithSecurityInEUR test examples with complete method implementations - Added multi-language test file naming conventions (German/English) - Documented proper test organization and sorting patterns - Added foreign currency test patterns with CheckCurrenciesAction validation ### Code Patterns & Best Practices - Enhanced DocumentType patterns with proper line break examples - Emphasized consistent use of `//` for line breaks in method chains - Added comprehensive ExtractorMatchers examples for all transaction types - Documented special Comdirect patterns for document pairing scenarios ### Structure & References - Updated reference implementations to point to proven extractors - Added Special Implementation Patterns section for complex scenarios - Improved test case organization with systematic naming guidelines - Streamlined contributing guidelines and removed outdated references ## Impact: This update provides Claude.ai with accurate, current guidance for PDF extractor implementation, focusing on standard patterns used throughout the codebase rather than edge cases. The documentation now properly reflects established practices from reference implementations like BaaderBankPDFExtractor and ComdirectPDFExtractor.
Nirus2000
deleted the
Create-new-CLAUDE-IMPORTER.md-and-CONTRIBUTING.md
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @buchen,
I've created and updated
CLAUDE-IMPORTER.mdthat serves as referencedocumentation for Claude.ai when developing PDF importers.
Key Updates:
component descriptions
addTaxesSectionsTransaction()and
addFeesSectionsTransaction()patterns from BaaderBankPDFExtractorfixed WithSecurityInEUR examples
conventions (Buy01.txt, Kauf01.txt, etc.)
//line break usagePurpose:
etc.)
Benefits:
The documentation is intentionally reference-oriented, pointing to
existing proven extractors rather than prescribing specific implementation
approaches.
Feedback welcome!