-
Notifications
You must be signed in to change notification settings - Fork 704
Rework MEXC to fix wierd performances, Add Binance USDs-M Futures Quote Feed #5054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also, imo there's no need to add cache, as the code is directly edited from BinanceQuoteFeed.java and should work perfectly. |
@earthjasonlin See comment in #5048 |
Hi @earthjasonlin, first, I picked up the rework to the MEXC feed: 4977066 But without the removal of the caching. As argued in #5048, I want to avoid duplicate calls right after each other. The caching for 1 minute avoids the "latest download" does not execute the same query that was done before. Keep in mind that the dialog to edit the feed provider (HistoricalQuoteProviderPage) also does some caching (the idea being that if the user flips back between providers, we are not requesting the remote data again). Maybe that resulted in the weird behavior you have seen? If you disagree, feel free to open another pull request. I would also need a better understanding what the "weird" is exactly. Second, I merged the new USDs-M feed. Thank you. I did some refactoring to pull the common pieces here: 594e7ff If you have the time, I would appreciate if you could test. The Finance feed is also missing the caching... I will add that when I find the time. |
Rework MEXC to fix wierd performances
Issue: #5048
PR: #5029
Commit: fdcf3f7 725dc71
Add Binance USDs-M Futures
Some that don't exist in spot do exist in futures like HYPEUSDT ASTERUSDT