Skip to content

Conversation

earthjasonlin
Copy link
Contributor

@earthjasonlin earthjasonlin commented Oct 5, 2025

Rework MEXC to fix wierd performances

Issue: #5048
PR: #5029
Commit: fdcf3f7 725dc71

Add Binance USDs-M Futures

Some that don't exist in spot do exist in futures like HYPEUSDT ASTERUSDT

@earthjasonlin
Copy link
Contributor Author

Also, imo there's no need to add cache, as the code is directly edited from BinanceQuoteFeed.java and should work perfectly.
Sorry for my mistakes before

@earthjasonlin earthjasonlin marked this pull request as draft October 5, 2025 16:28
@earthjasonlin earthjasonlin changed the title Rework MEXC to fix wierd performances Rework MEXC to fix wierd performances, Add Binance USDs-M Futures Oct 5, 2025
@earthjasonlin earthjasonlin changed the title Rework MEXC to fix wierd performances, Add Binance USDs-M Futures Rework MEXC to fix wierd performances Oct 5, 2025
@earthjasonlin earthjasonlin marked this pull request as ready for review October 5, 2025 17:30
@earthjasonlin earthjasonlin changed the title Rework MEXC to fix wierd performances Rework MEXC to fix wierd performances, Add Binance USDs-M Futures Quote Feed Oct 6, 2025
@buchen
Copy link
Member

buchen commented Oct 7, 2025

@earthjasonlin See comment in #5048

@buchen buchen self-assigned this Oct 7, 2025
@buchen buchen added the question label Oct 7, 2025
buchen pushed a commit that referenced this pull request Oct 10, 2025
buchen pushed a commit that referenced this pull request Oct 10, 2025
buchen added a commit that referenced this pull request Oct 10, 2025
buchen pushed a commit that referenced this pull request Oct 10, 2025
buchen pushed a commit that referenced this pull request Oct 10, 2025
buchen added a commit that referenced this pull request Oct 10, 2025
@buchen
Copy link
Member

buchen commented Oct 10, 2025

Hi @earthjasonlin,

first, I picked up the rework to the MEXC feed: 4977066 But without the removal of the caching. As argued in #5048, I want to avoid duplicate calls right after each other. The caching for 1 minute avoids the "latest download" does not execute the same query that was done before. Keep in mind that the dialog to edit the feed provider (HistoricalQuoteProviderPage) also does some caching (the idea being that if the user flips back between providers, we are not requesting the remote data again). Maybe that resulted in the weird behavior you have seen?

If you disagree, feel free to open another pull request. I would also need a better understanding what the "weird" is exactly.

Second, I merged the new USDs-M feed. Thank you. I did some refactoring to pull the common pieces here: 594e7ff If you have the time, I would appreciate if you could test.

The Finance feed is also missing the caching... I will add that when I find the time.

@buchen buchen closed this Oct 10, 2025
arnonm pushed a commit to arnonm/portfolio that referenced this pull request Oct 15, 2025
arnonm pushed a commit to arnonm/portfolio that referenced this pull request Oct 15, 2025
arnonm pushed a commit to arnonm/portfolio that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants