Update to Rust 1.87 and Rust 2024 edition#372
Merged
DavisVaughan merged 5 commits intomainfrom Jul 22, 2025
Merged
Conversation
Many changes around capitalization ordering, and some around function calls within macros
This was referenced Jun 20, 2025
Collaborator
Author
|
I now see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #302, which notes how we are tied to cargo-xwin's latest version in their Dockerfile for ARM Windows. Note that they have recently updated that Dockerfile to use Rust 1.87, so we should be able to use it too https://github.com/rust-cross/cargo-xwin/blob/main/Dockerfile.
Rust 2024 edition came with a few rustfmt updates. I ran
cargo fmton the whole project (note we don't use+nightlylike we do in Ark). They look harmless.I'll do a dry-run of building the binaries to ensure it works as expected on all platforms.