Fix regression in region detection #857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes addressing posit-dev/positron#8059 (see #842 for first part).
I mistakenly thought that VSCode regions were spec'd as:
I.e. you need
// #region
in Javascript or C. However I now see that for Python, which shares with R the#
symbol as comment opener, it's actually:See https://github.com/microsoft/vscode/blob/d6d5034ff685d6aab2c1f226fef288455caa7a14/extensions/python/language-configuration.json#L45-L48
So I've just copied over their regexes for detection of regions.