Don't emit nested objects as document symbols #859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
force-pushed
the
feature/method-symbols
branch
from
698f1a3 to
f67b10f
Compare
lionel-
force-pushed
the
feature/top-level-assign-symbols
branch
from
5e3988d to
a4f5a00
Compare
This was referenced Jul 5, 2025
DavisVaughan
approved these changes
Jul 16, 2025
| // Otherwise, collect as generic object | ||
| let name = contents.node_slice(&lhs)?.to_string(); | ||
| if ctx.top_level || ctx.include_assignments_in_blocks { | ||
| // Collect as generic object, but only if we're at top-level. Assigned |
There was a problem hiding this comment.
Suggested change
| // Collect as generic object, but only if we're at top-level. Assigned | |
| // Collect as generic object, but typically only if we're at top-level. Assigned |
| foo.detail = Some(String::from("function()")); | ||
|
|
||
| assert_eq!(test_symbol("foo <- function() { bar <- 1 }"), vec![foo]); | ||
| insta::assert_debug_snapshot!(test_symbol("foo <- function() { bar <- function() 1 }")); |
There was a problem hiding this comment.
I think it would be worth also having a snapshot test that sets include_assignments_in_blocks to true if you can easily expose that toggle
| // Assigned variables in nested contexts are not emitted as symbols | ||
| fn test_symbol_nested_assignments() { | ||
| insta::assert_debug_snapshot!(test_symbol( | ||
| " |
There was a problem hiding this comment.
And, to be super clear, at top level we do want assigned variables to be treated as symbols?
I honestly don't think that sounds super useful either
Like, a 300 line R script is bound to have a ton of assignments, and I'm not sure that seeing them in the outline feels that useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #858
Addresses posit-dev/positron#8330
Objects assigned in
{}blocks are currently emitted as document symbols, which causes the ouline and document symbol search (@prefix in command palette) to be quite busy:Screen.Recording.2025-06-27.at.15.18.45.mov
Here is how it looks like if we only emit top-level objects:
Screen.Recording.2025-06-27.at.15.20.35.mov
This is controllable via a new
"positron.r.symbols.includeAssignmentsInBlockssetting. By default we don't include these nested assignments.QA Notes
You should see the new setting in the config UI:
It's documented that files need to be reopened (they can also be changed) or the server restarted for this setting to take effect.