Extend range of assignment symbols to end of node #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
force-pushed
the
feature/method-symbols
branch
from
698f1a3 to
f67b10f
Compare
lionel-
force-pushed
the
bugfix/assigned-symbol-range
branch
from
13ff3ff to
37c13ce
Compare
DavisVaughan
approved these changes
Jul 16, 2025
| let start = convert_point_to_position(contents, lhs.start_position()); | ||
| let end = convert_point_to_position(contents, lhs.end_position()); | ||
| let start = convert_point_to_position(contents, node.start_position()); | ||
| let end = convert_point_to_position(contents, node.end_position()); | ||
|
|
||
| // Now recurse into RHS |
There was a problem hiding this comment.
I don't have super deep intuition about how this should work, but from what I can tell:
- If you have an assigned multi line function call, you get a breadcrumb
- If you have a free floating multi line function call, you do not
Is that expected / consistent? It feels like maybe we should get a breadcrumb in both cases? Not totally sure. Probably worth comparing to other languages
Screen.Recording.2025-07-16.at.9.35.06.AM.mov
There was a problem hiding this comment.
I think that's expected, function calls are not emitted as document symbols. Otherwise every single function call would show up in the outline.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #858
This fix is similar to #855
It makes sure the range of document symbol of assigned objects fully extends up to the end of the RHS. This allows the breadcrumbs to behave much better with the method symbols implemented in #858.
Before:
Screen.Recording.2025-06-27.at.15.37.29.mov
After:
Screen.Recording.2025-06-27.at.15.36.23.mov