Treat all documented names as known symbols#883
Merged
Conversation
DavisVaughan
approved these changes
Jul 29, 2025
Contributor
|
Reviewed together over zed |
1d47d9f to
a974de9
Compare
37f7c6e to
e31cd00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from #872.
Progress towards posit-dev/positron#8521
Addresses posit-dev/positron#8708
This adds all symbol-looking documentation topics to our set of known exported symbols to cover exported datasets. This information is installed in an INDEX file that we can inspect statically: https://cran.r-project.org/doc/manuals/r-devel/R-exts.html#The-INDEX-file-1. This INDEX file might be manually written by the package author (see link above), and so might throw off our attempts at parsing this unstructured file. That said I expect it's automatically generated in the vast majority of cases
This stopgap approach will potentially produce false negatives:
LazyDatais true or false. In the false case, the dataset is only exported after a correspondingdata()call.For now though, we prefer to avoid false positives and spurious diagnostics.
QA Notes
In a fresh session with:
You should only see diagnostics before the
library()calls: