Show summary of total vulnerability count #233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosnav
approved these changes
Jul 10, 2025
Comment on lines
54
to
61
| return scannerStore.content.reduce( | ||
| (acc, item) => acc + item.vulnerabilityCount, | ||
| 0, | ||
| ); | ||
| }); | ||
|
|
||
| const anyContentLoadingPackages = computed<boolean>(() => { | ||
| return scannerStore.content.some((content) => content.isLoadingPackages); |
There was a problem hiding this comment.
Similar minor suggestion as the other PR, might be good to have operations to scannerStore.content.* to be getters or methods within the same scannerStore, e.g: scannerStore.totalVulnerabilities and scannerStore.isLoadingPackages
There was a problem hiding this comment.
Yeah these can pretty easily be moved over to scannerStore good call 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new line on the first package of the Package Vulnerability Scanner showing the total number of content items and the total number of vulnerabilities across them.
Fixes #208
While the package data is loading it uses a
SkeletonTextcomponent to show a shimmering box to imply that data is still loading in. This can be seen in the preview below.Preview
CleanShot.2025-07-09.at.13.57.30.mp4
These changes have been published to our internal Dogfood server here.