Include tabs to show all content or filter vulnerable content #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcosnav
approved these changes
Jul 10, 2025
| @@ -57,9 +58,46 @@ const totalVulnerabilities = computed<number>(() => { | |||
| ); | |||
| }); | |||
|
|
|||
| const contentWithVulnerabilities = computed<number>(() => { | |||
| return scannerStore.content.filter((item) => item.vulnerabilityCount > 0) | |||
There was a problem hiding this comment.
Good call I'll move that over to isolate the logic a bit better.
Comment on lines
9
to
14
| :class="[ | ||
| model === tab.name | ||
| ? getActiveTabClasses(tab.color) | ||
| : 'border-transparent text-gray-600 hover:border-gray-300 hover:text-gray-700', | ||
| 'flex items-center border-b-2 px-4 py-2 text-sm font-medium whitespace-nowrap cursor-pointer', | ||
| ]" |
There was a problem hiding this comment.
Feels a bit overloaded to have this in the template
There was a problem hiding this comment.
Yeah perhaps it would be better to have this be a separate component to isolate it a bit better or have a method to construct the non-default classes. I'll take a look at that.
There was a problem hiding this comment.
Ended up splitting up class and the computed :class. I didn't split out the inactive classes since that would just put a class const in the script which felt odd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes tabs (and a new component to support them) for the content list page in the Package Vulnerability Scanner.
This allows users to select "With Vulnerabilities" to show only content with vulnerabilities. A badge is included for each tab to show the number of content items for both tabs.
Fixes #211
Preview
These changes have been published to our internal Dogfood server here.