Add experimental gradual typing for development #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I think we should leave this branch open, it's easy for me to come in and gradually type a few things and push. |
|
This is so great, ty! |
|
No worries! Whenever you want to merge feel free, I'm just going to keep pushing stuff |
|
Do you want to merge these periodically? i don't think i'll be able to get all of this in one shot |
|
@tylerriccio33 Could you update this branch with the current |
I missed a merge marker resulting in a huge diff.
|
Ok this should all be good. Missed a merge marker in test_validate.py so had to do some gymnastics to get back in sync. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a little support and considerations for local/dev type checking. I add ty (astral's new experimental type checker) to the makefile, add pointblank/py.typed to the ignore file and updated the documentation to say you can type check but it's not enforced. I think as time goes on, I'll start gradually typing things, and maybe one day it can get into the CI checks. For now, this is just helpful for development, especially if you're so used to relying on a type checker (i am).
Also, random but I found pytest-xdist was repeated in the dependencies so i removed it.