Skip to content

Merge upstream 1.106.0 into Positron#10637

Merged
jmcphers merged 30 commits intomainfrom
merge/1.106.0
Nov 20, 2025
Merged

Merge upstream 1.106.0 into Positron#10637
jmcphers merged 30 commits intomainfrom
merge/1.106.0

Conversation

@jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Nov 18, 2025

Updates Positron with changes from VS Code October 2025:

https://code.visualstudio.com/updates/v1_106

Addresses #10349.

Release Notes

New Features

@jmcphers jmcphers requested a review from juliasilge November 18, 2025 18:59
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@jmcphers jmcphers requested a review from timtmok November 18, 2025 18:59
@juliasilge
Copy link
Contributor

juliasilge commented Nov 19, 2025

I made a dev build and am running into a few problems 😅

Screenshot 2025-11-18 at 5 44 19 PM

I have not been able to reproduce the kernel supervisor crash (just happened one time), but the problem with Copilot seems to be real. It looks to me like I successfully connect/auth and I am getting completions, but I see this error when trying to use chat:

No language models available for chat. Please ensure you have logged into Anthropic as a language model provider by clicking Configure Model Providers... or running the command Positron Assistant: Configure Language Model Providers and authenticating with Anthropic.

I am not currently authenticated to Anthropic. This is after I blew away my dev build state so I was in a very fresh situation.

I am seeing the message "Cmd click to launch VS Code Native REPL" in the Python console about one out of every 5 times I am starting it, but that code is in extensions/positron-python so I don't see how it can be related to this upstream merge.

@jmcphers
Copy link
Collaborator Author

Is it possible your dev build doesn't have the updated version of the chat extension? (did you git submodule update after sync but before npm install)?

@juliasilge
Copy link
Contributor

I just did some massive clearing of state and rebuilding as freshly as possible, including git submodule update:

Screenshot 2025-11-19 at 9 59 01 AM

and I do still see problems using Copilot for chat:

Screenshot 2025-11-19 at 9 59 50 AM

@midleman
Copy link
Contributor

I’ve noticed that the blob reports generated during the e2e tests (specifically in this PR) are quite large. For instance, merging these reports together can take up to 13 minutes because each report is multiple gigabytes in size. On the main branch, this typically takes only about 1 minute. If we restore the changes from this dir back to our current state, I believe it will resolve the issue: test/e2e/infra.

@jmcphers
Copy link
Collaborator Author

@midleman

If we restore the changes from this dir back to our current state

thanks! Done: 87683a8

Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It turns out that my problem was that on my brand new computer, I had never done this part of our machine setup:

git submodule update --init --recursive

Apologies! 🙈

Now that I have that correctly setup, I am able to make a dev build and Positron is acting as expected, including Copilot chat:

Image

I spot-checked behavior in the console, Quarto files, Data Explorer, etc.

Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmcphers jmcphers merged commit d49b1e9 into main Nov 20, 2025
25 of 29 checks passed
@jmcphers jmcphers deleted the merge/1.106.0 branch November 20, 2025 23:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants