Open
Conversation
|
E2E Tests 🚀 |
juliasilge
approved these changes
Mar 17, 2026
Contributor
juliasilge
left a comment
There was a problem hiding this comment.
This improves the experience when you have multiple affiliated runtimes A LOT. 🙌
With these changes and 3 affiliated runtimes, I don't see them grabbing focus from each other as they come online.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Positron startup much calmer when multiple affiliated runtimes exist. The changes are pretty simple:
selectLanguageRuntimeis called during startup, do not allow it to override the runtime selection process that happens at startup. (The Python extension does this.)With these changes, you will also notice fewer unwanted Pythons starting in R environments. Since these changes make it possible for the Python console to go completely unused (never focused) in a Positron session, the dormant logic that switches off unused languages can come back into play.
There is a big caveat here, however, which is that the Python extension is still aggressively starting Python in workspaces that don't want or need it. Depending on the timing, this can negate much of the benefits of the above changes; once startup is complete from Positron's perspective, it allows the Python extension to start a new Python if it wants to, and this will focus the new Python session and establish an affiliation. I didn't try to tackle this problem since it is scheduled for work soon in #12116.
Addresses #10929.
Release Notes
New Features
Bug Fixes
QA Notes
This change specifically addresses startup issues for workspaces that have affiliated runtimes (that is, we know ahead of time which to start). If you observe problematic behavior, use the Runtime Startup Diagnostics report. If you see this, you should have a "calm" startup:
If you see Python starting due to "extension requested" activation, then you may still experience some dancing at startup.
Test tags:
@:console@:sessions